Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(karma-webpack): normalize paths (windows) #353

Merged

Conversation

alabbas-ali
Copy link
Contributor

@alabbas-ali alabbas-ali commented Sep 4, 2018

This error show on windows OS:

04 09 2018 16:02:38.163:ERROR [karma]: TypeError: Path must be a string. Received undefined
  at assertPath (path.js:28:11)
  at Object.join (path.js:499:7)
  at Plugin.<anonymous> (..\node_modules\karma-webpack\lib\karma-webpack.js:262:68)
  at Plugin.readFile (..\node_modules\karma-webpack\lib\karma-webpack.js:281:5)
  at _combinedTickCallback (internal/process/next_tick.js:131:7)
  at process._tickCallback (internal/process/next_tick.js:180:9)
04 09 2018 16:02:38.178:ERROR [karma]: TypeError: Path must be a string. Received undefined
  at assertPath (path.js:28:11)
  at Object.join (path.js:499:7)
  at Plugin.<anonymous> (..\node_modules\karma-webpack\lib\karma-webpack.js:262:68)
  at Plugin.readFile (..\node_modules\karma-webpack\lib\karma-webpack.js:281:5)
  at _combinedTickCallback (internal/process/next_tick.js:131:7)
  at Immediate._tickCallback [as _onImmediate] (internal/process/next_tick.js:180:9)
  at runCallback (timers.js:789:20)
  at tryOnImmediate (timers.js:751:5)
  at processImmediate [as _immediateCallback] (timers.js:722:5)

The output assets array has indexes like 'path/to/file' and the file name is 'path\to\file'

Type

  • Fix

Issues

SemVer

  • Patch

@jsf-clabot
Copy link

jsf-clabot commented Sep 4, 2018

CLA assistant check
All committers have signed the CLA.

@michael-ciniawsky michael-ciniawsky changed the title 🐛 fix output assets path undefined fix(karma-webpack): normalize asset paths Sep 6, 2018
@michael-ciniawsky michael-ciniawsky changed the title fix(karma-webpack): normalize asset paths [v3.x] fix(karma-webpack): normalize asset paths Sep 6, 2018
src/karma-webpack.js Outdated Show resolved Hide resolved
@michael-ciniawsky michael-ciniawsky changed the title [v3.x] fix(karma-webpack): normalize asset paths fix(karma-webpack): normalize paths (windows) Sep 7, 2018
Copy link
Contributor

@michael-ciniawsky michael-ciniawsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@michael-ciniawsky
Copy link
Contributor

Released in v3.0.3 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants