New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make generated project fully compatible with Edge #20
Comments
So, I wrote a task list (because I like task lists):
The first two item looks like an easy win to me. But the last one... |
For the last task, I will follow mozilla/webextension-polyfill#154 as well |
Depends on mozilla/webextension-polyfill#114 |
Hi @JimMorrison723, Because Edge will switch Chromium base, I closed this Issue and PR #26. For further explanation, please see rpl's comment here: Kind regards, |
Hi @balcsida! |
Expected Behavior
Full Edge support out-of-the-box.
Current Behavior
After generating extension, we have to manually add
author
field to manifest.json andpersistent
property to the background page object.Also, Edge doesn't support promises (yet), maybe use this polyfill version?
Steps to Reproduce (for bugs)
Suggestion
1., Add persistent to manifest file by default (if we select to add background page), like this:
Documentation
Browser compatibility (not supported in firefox)
2., Simply add
author
property to default manifest.jsonDocumentation (This key is mandatory in Microsoft Edge.)
3., Polyfill to Edge version
If i simply add the polyfill,
browser
will be undefined. I assume using this fixes the issue. Needs testing.Documentation (Microsoft Edge extension APIs use callbacks, not promises.)
Your Environment
The text was updated successfully, but these errors were encountered: