From d5d1b0da4a5089bf87d3edc1ef6261ccffcb3d39 Mon Sep 17 00:00:00 2001 From: martineez Date: Wed, 27 Sep 2017 17:28:32 +0200 Subject: [PATCH] geckodriver updated to 0.19.0 (#33) --- README.md | 2 ++ index.js | 13 +++++++------ lib/geckodriver.js | 2 +- test/index.js | 2 +- 4 files changed, 11 insertions(+), 8 deletions(-) diff --git a/README.md b/README.md index 55917c4..47dd637 100644 --- a/README.md +++ b/README.md @@ -64,6 +64,7 @@ Binaries on your CDN should be located in a subdirectory of the above base URL. ## Versions * [npm module version] - [geckodriver version] +* 1.9.x - geckodriver 0.19.0 * 1.8.x - geckodriver 0.18.0 * 1.7.x - geckodriver 0.17.0 * 1.6.x - geckodriver 0.16.1 @@ -75,6 +76,7 @@ Binaries on your CDN should be located in a subdirectory of the above base URL. ## Changelog +* 1.9.0 - updated to geckodriver 0.19.0 32-bit windows support removed. * 1.8.1 - added geckodriver.exe bin for Windows * 1.8.0 - updated to geckodriver 0.18.0 * 1.7.1 - 'GECKODRIVER_CDNURL' support added. diff --git a/index.js b/index.js index 637a0ff..e589a48 100644 --- a/index.js +++ b/index.js @@ -16,11 +16,11 @@ var baseCDNURL = process.env.GECKODRIVER_CDNURL || 'https://github.com/mozilla/g // Remove trailing slash if included baseCDNURL = baseCDNURL.replace(/\/+$/, ''); -var DOWNLOAD_MAC = baseCDNURL + '/v0.18.0/geckodriver-v0.18.0-macos.tar.gz'; -var DOWNLOAD_LINUX64 = baseCDNURL + '/v0.18.0/geckodriver-v0.18.0-linux64.tar.gz'; -var DOWNLOAD_LINUX32 = baseCDNURL + '/v0.18.0/geckodriver-v0.18.0-linux32.tar.gz'; -var DOWNLOAD_WIN32 = baseCDNURL + '/v0.18.0/geckodriver-v0.18.0-win32.zip'; -var DOWNLOAD_WIN64 = baseCDNURL + '/v0.18.0/geckodriver-v0.18.0-win64.zip'; +var DOWNLOAD_MAC = baseCDNURL + '/v0.19.0/geckodriver-v0.19.0-macos.tar.gz'; +var DOWNLOAD_LINUX64 = baseCDNURL + '/v0.19.0/geckodriver-v0.19.0-linux64.tar.gz'; +var DOWNLOAD_LINUX32 = baseCDNURL + '/v0.19.0/geckodriver-v0.19.0-linux32.tar.gz'; +var DOWNLOAD_WIN32 = baseCDNURL + '/v0.19.0/geckodriver-v0.19.0-win32.zip'; +var DOWNLOAD_WIN64 = baseCDNURL + '/v0.19.0/geckodriver-v0.19.0-win64.zip'; // TODO: move this to package.json or something var downloadUrl = DOWNLOAD_MAC; @@ -32,7 +32,8 @@ if (platform === 'linux') { } if (platform === 'win32') { - downloadUrl = arch === 'x64' ? DOWNLOAD_WIN64 : DOWNLOAD_WIN32; + // No 32-bits of geckodriver for now + downloadUrl = arch === 'x64' ? DOWNLOAD_WIN64 : DOWNLOAD_WIN64; outFile = 'geckodriver.zip'; executable = 'geckodriver.exe'; } diff --git a/lib/geckodriver.js b/lib/geckodriver.js index 4bf9f18..82dbe8f 100644 --- a/lib/geckodriver.js +++ b/lib/geckodriver.js @@ -7,7 +7,7 @@ process.env.PATH += path.delimiter + path.join(__dirname, '..'); exports.path = process.platform === 'win32' ? path.join(__dirname, '..', 'geckodriver.exe') : path.join(__dirname, '..', 'geckodriver'); // specify the version of geckodriver -exports.version = '0.18.0'; +exports.version = '0.19.0'; exports.start = function(args) { exports.defaultInstance = require('child_process').execFile(exports.path, args); diff --git a/test/index.js b/test/index.js index 90a9695..d565d00 100644 --- a/test/index.js +++ b/test/index.js @@ -14,5 +14,5 @@ test.cb('properly extracts', t => { test('programmatic usage', t => { var driver = require('../lib/geckodriver') - t.is(driver.version, '0.18.0') + t.is(driver.version, '0.19.0') });