Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix($shared-utils): Slugify em/en dash in urls #2174

Merged
merged 1 commit into from Feb 23, 2020
Merged

fix($shared-utils): Slugify em/en dash in urls #2174

merged 1 commit into from Feb 23, 2020

Conversation

wdporter
Copy link
Contributor

@wdporter wdporter commented Feb 7, 2020

Summary

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • [*] Other, please describe:

enhancement, added to the range of characters handled by markdown.slugify

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • [*] No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

@wdporter
Copy link
Contributor Author

wdporter commented Feb 7, 2020

my headings use a lot of en dash or em dash (unicode 2013, 2014), and they really should just be ignored in the slugify functions, instead i'm getting "%E2%80%93" in my slugs for them (and 94)

@wdporter wdporter closed this Feb 7, 2020
@wdporter wdporter reopened this Feb 7, 2020
Copy link
Collaborator

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @W-David-Porter, one more review and we'll get this merged 👍

@kefranabg kefranabg changed the title fix($shared-utils): Add en/em dash to rSpecial fix($shared-utils): Slugify em/en dash in urls Feb 23, 2020
@kefranabg kefranabg merged commit 8d9968d into vuejs:master Feb 23, 2020
larionov pushed a commit to larionov/vuepress that referenced this pull request Aug 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants