Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contributors commit link to the correct repository #1809

Merged
merged 1 commit into from
Aug 28, 2019
Merged

fix: contributors commit link to the correct repository #1809

merged 1 commit into from
Aug 28, 2019

Conversation

kamalhm
Copy link
Contributor

@kamalhm kamalhm commented Aug 28, 2019

Summary
The commits link in the readme.md were referencing the wrong repository (ulivz/vuepress) which did not exist anymore, fixed to vuejs/vuepress

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

Other information:

Minor documentation change

Copy link
Collaborator

@kefranabg kefranabg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kamalhm, thanks for this 👍Could you update your commit and PR title to match the semantic PR requirements ?

@kamalhm kamalhm changed the title fixed contributors commit link to the correct repository fix: contributors commit link to the correct repository Aug 28, 2019
@kamalhm
Copy link
Contributor Author

kamalhm commented Aug 28, 2019

I've edited the PR title to match with the semantic PR, is that correct? Sorry this is my first time contributing 😅

edit:

how can I fix the commit message? do I have to undo this and create another pull request?

@kefranabg
Copy link
Collaborator

@kamalhm No problem 😉 what you need to do is rewrite your commit history, you can do it with git commit --amend for example

@kefranabg kefranabg merged commit bb61182 into vuejs:master Aug 28, 2019
@vue-bot
Copy link

vue-bot commented Aug 28, 2019

Hey @kamalhm, thank you for your time and effort spent on this PR, contributions like yours help make Vue better for everyone. Cheers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants