Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome autofill triggers keyup event on render/load #9441

Comments

@DRoet
Copy link

DRoet commented Feb 6, 2019

Version

2.6.2

Reproduction link

https://codepen.io/anon/pen/jdGjZx

Steps to reproduce

  1. open the codepen
  2. fill in username/password and force chrome to save them
  3. reload the page
  4. chrome will fill in the username/password
  5. console.log will show "triggered" twice

What is expected?

The autofill won't trigger the event listeners (worked in 2.5.22)

What is actually happening?

chrome autofill triggers the event listeners on render/load

@Justineo
Copy link
Member

Justineo commented Feb 6, 2019

Can't reproduce on my side...What's your Chrome version?

@jacekkarczmarczyk
Copy link

Confirming on Chrome 72 win10

@DRoet
Copy link
Author

DRoet commented Feb 6, 2019

Using chrome 72.0.3626.81, however I'm also getting the trigger when I select/focus on the input in chrome 71

@aaaguirrep
Copy link

I have the same issue with a keyup event. I didn't have the issue with 2.5.22 version. The issue is just with chrome, my current chrome version is: 72.0.3626.96 (64 bits) on windows 10. I dont have the issue with firefox.

klinker24 added a commit to Serubin/pulse-sms-web that referenced this issue Feb 9, 2019
keyup was auto logging-in, when the browser filled the password field... that is bad: vuejs/vue#9441
@grzegorztomasiak
Copy link

I can confirm the issue too on keyup and keydown. Exists in Vue 2.6.3 and the latest 2.6.5.
It just triggers that event when we click on item in autocomplete in Chrome and Opera. Firefox is fine.

@nghiepdev
Copy link

I have the same issue

@grzegorztomasiak
Copy link

grzegorztomasiak commented Feb 12, 2019

@yyx990803 Thanks Evan for this fix. Just updated Vue to 2.6.6 and it had fixed the issue but I noticed that autocomplete feature still triggers @keydown.esc="onEsc" event modifier (only with esc so far I see).

EDIT: Apparently it was something weird on my side. So nothing to do.
2.6.6 fixes this issue.

@qnp
Copy link

qnp commented Feb 14, 2019

Thanks a lot. Keep up awsome work

Lostlover pushed a commit to Lostlover/vue that referenced this issue Dec 10, 2019
@jwbats
Copy link

jwbats commented Mar 26, 2021

I'm currently experiencing this problem with VueJS 2.6.12 on Chrome 89.

Both KeyUp & KeyDown will fire on Chrome's autofill of email & password inputs.

KeyPress, thankfully, does not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment