You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy repository, type npm install and npm run serve to check.
To "test" it remove comments from TestComponent and TestComponentWithTransition components and check behaviour.
What is actually happening?
When using compilerOptions: { whitespace: "preserve" } vue-loader option HTML comments are breaking functionality of components:
"class" attribute is not being passed from parent to child properly when there is a comment in the child template root
transition components using slots are not being rendered at all
Those are two found by me. There can be more related issues.
What is expected?
Comments are not breaking functionality of components.
With HTML comments in the code:
Without HTML comments in the code:
The text was updated successfully, but these errors were encountered:
// attr merging// in dev mode, comments are preserved, and it's possible for a template// to have comments along side the root element which makes it a fragment
seems they added a condition for development environment but if you have comments in production you will have this problem
at least vue-loader should warn developers that root level comments are not welcome
Version
17.0.1
Reproduction link
https://github.com/bartoszrudzinski/vue-loader-bug
Steps to reproduce
Copy repository, type
npm install
andnpm run serve
to check.To "test" it remove comments from
TestComponent
andTestComponentWithTransition
components and check behaviour.What is actually happening?
When using
compilerOptions: { whitespace: "preserve" }
vue-loader option HTML comments are breaking functionality of components:Those are two found by me. There can be more related issues.
What is expected?
Comments are not breaking functionality of components.
With HTML comments in the code:
Without HTML comments in the code:
The text was updated successfully, but these errors were encountered: