Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use only public APIs of ESLint #171

Closed
mysticatea opened this issue Sep 1, 2017 · 5 comments
Closed

Use only public APIs of ESLint #171

mysticatea opened this issue Sep 1, 2017 · 5 comments
Assignees
Labels

Comments

@mysticatea
Copy link
Member

Link: eslint/eslint#9193.

vue-eslint-parser has been depending on the private API to traverse <template>'s AST, so we have to fix it to work on ESLint v4.6.0.

@mysticatea mysticatea added the bug label Sep 1, 2017
@mysticatea mysticatea self-assigned this Sep 1, 2017
@not-an-aardvark
Copy link

Is it possible to fix this with ESLint's public API? If not, I can revert the change in ESLint until there is a better solution.

@mysticatea
Copy link
Member Author

Yes, I can. I will fix it ASAP. Thank you!

@LinusBorg
Copy link
Member

Quick question about this: I'm maintiaining our vue webpack template and was thinking about bumping eslint to the latest version (the template is currently on eslint 3.*). Should I wait until this is fixed? What'S the estimated timeline on this?

@mysticatea
Copy link
Member Author

Should I wait until this is fixed?

I recommend that you wait for either:

I can't promise the time of the releasing since I don't have the permission to release.

@michalsnik Could you take a look this?

@mysticatea mysticatea changed the title ESLint v4.6.0 supports Use only public APIs of ESLint Sep 2, 2017
michalsnik pushed a commit that referenced this issue Sep 3, 2017
* Fix: don't use internal APIs of ESLint (fixes #171)

* Chore: add tests with old ESLint
@michalsnik
Copy link
Member

Fixed in v3.13.0 🚀 thanks @mysticatea 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants