Skip to content

Commit

Permalink
geckodriver updated to 0.19.0 (#33)
Browse files Browse the repository at this point in the history
  • Loading branch information
martineez authored and vladikoff committed Sep 27, 2017
1 parent cbfb004 commit d5d1b0d
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 8 deletions.
2 changes: 2 additions & 0 deletions README.md
Expand Up @@ -64,6 +64,7 @@ Binaries on your CDN should be located in a subdirectory of the above base URL.
## Versions

* [npm module version] - [geckodriver version]
* 1.9.x - geckodriver 0.19.0
* 1.8.x - geckodriver 0.18.0
* 1.7.x - geckodriver 0.17.0
* 1.6.x - geckodriver 0.16.1
Expand All @@ -75,6 +76,7 @@ Binaries on your CDN should be located in a subdirectory of the above base URL.

## Changelog

* 1.9.0 - updated to geckodriver 0.19.0 32-bit windows support removed.
* 1.8.1 - added geckodriver.exe bin for Windows
* 1.8.0 - updated to geckodriver 0.18.0
* 1.7.1 - 'GECKODRIVER_CDNURL' support added.
Expand Down
13 changes: 7 additions & 6 deletions index.js
Expand Up @@ -16,11 +16,11 @@ var baseCDNURL = process.env.GECKODRIVER_CDNURL || 'https://github.com/mozilla/g
// Remove trailing slash if included
baseCDNURL = baseCDNURL.replace(/\/+$/, '');

var DOWNLOAD_MAC = baseCDNURL + '/v0.18.0/geckodriver-v0.18.0-macos.tar.gz';
var DOWNLOAD_LINUX64 = baseCDNURL + '/v0.18.0/geckodriver-v0.18.0-linux64.tar.gz';
var DOWNLOAD_LINUX32 = baseCDNURL + '/v0.18.0/geckodriver-v0.18.0-linux32.tar.gz';
var DOWNLOAD_WIN32 = baseCDNURL + '/v0.18.0/geckodriver-v0.18.0-win32.zip';
var DOWNLOAD_WIN64 = baseCDNURL + '/v0.18.0/geckodriver-v0.18.0-win64.zip';
var DOWNLOAD_MAC = baseCDNURL + '/v0.19.0/geckodriver-v0.19.0-macos.tar.gz';
var DOWNLOAD_LINUX64 = baseCDNURL + '/v0.19.0/geckodriver-v0.19.0-linux64.tar.gz';
var DOWNLOAD_LINUX32 = baseCDNURL + '/v0.19.0/geckodriver-v0.19.0-linux32.tar.gz';
var DOWNLOAD_WIN32 = baseCDNURL + '/v0.19.0/geckodriver-v0.19.0-win32.zip';
var DOWNLOAD_WIN64 = baseCDNURL + '/v0.19.0/geckodriver-v0.19.0-win64.zip';

// TODO: move this to package.json or something
var downloadUrl = DOWNLOAD_MAC;
Expand All @@ -32,7 +32,8 @@ if (platform === 'linux') {
}

if (platform === 'win32') {
downloadUrl = arch === 'x64' ? DOWNLOAD_WIN64 : DOWNLOAD_WIN32;
// No 32-bits of geckodriver for now
downloadUrl = arch === 'x64' ? DOWNLOAD_WIN64 : DOWNLOAD_WIN64;
outFile = 'geckodriver.zip';
executable = 'geckodriver.exe';
}
Expand Down
2 changes: 1 addition & 1 deletion lib/geckodriver.js
Expand Up @@ -7,7 +7,7 @@ process.env.PATH += path.delimiter + path.join(__dirname, '..');
exports.path = process.platform === 'win32' ? path.join(__dirname, '..', 'geckodriver.exe') : path.join(__dirname, '..', 'geckodriver');

// specify the version of geckodriver
exports.version = '0.18.0';
exports.version = '0.19.0';

exports.start = function(args) {
exports.defaultInstance = require('child_process').execFile(exports.path, args);
Expand Down
2 changes: 1 addition & 1 deletion test/index.js
Expand Up @@ -14,5 +14,5 @@ test.cb('properly extracts', t => {

test('programmatic usage', t => {
var driver = require('../lib/geckodriver')
t.is(driver.version, '0.18.0')
t.is(driver.version, '0.19.0')
});

0 comments on commit d5d1b0d

Please sign in to comment.