Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(url): Pass parsed url to got (#28)
This allows for usage of things such as basic auth, and other features that node's built-in url library support that `got` expects. I only tested this by installing node-geckodriver via ``` GECKODRIVER_CDNURL="https://${ght}@github.com/mozilla/geckodriver/releases/download" npm link ../node-geckodriver/ ``` and confirmed that it no longer threw the error present in the upstream issue sindresorhus/got#184 ``` Error: Basic authentication must be done with auth option │$: git co master at normalizeArguments (~/code/project/node_modules/got/index.js:215:10) ```
- Loading branch information