Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
component: update "ms" to v2.0.0
- Loading branch information
d2dd80a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TooTallNate I believe this commit is breaking our build. Afaik there is no rauchg/ms.js@2.0.0. See https://github.com/rauchg/ms/releases. zeit/ms has the correct tag, see https://github.com/zeit/ms/releases. Would you mind looking into this asap, since this is a dependency of component/reactive. If there is a different way to fix, please let us know.
d2dd80a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frankly I wouldn't recommend using Component for your project. It's been deprecated since 2015. On that note it's probably time to remove the
component.json
from this project to help guide the community forward /cc @Qix- @thebigredgeekd2dd80a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to fill in the details, we haven't used component in a new project in over 4 years, this is legacy code from 5+ years ago.
d2dd80a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 to removing it. If you absolutely need component.json in here you'll probably need to add/maintain it yourself as it's just not something that should be encouraged or used anymore.
d2dd80a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah component is a PITA. I think we should remove it haha. If people wanna use it they can wrap debug in their own repos IMO
d2dd80a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took the liberty in 47747f3.
@AndreasKlein @erichmond Thank you for implicitly pushing the effort forward. I'm sorry to not address your issue directly but I would think that refactoring the app to use webpack or browserify or rollup or normalize or whatever flavour of the month is popular would be trivial.