Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): cursor fixes for disabled dates & weeks in datepicker #4905

Merged
merged 1 commit into from
Dec 7, 2018
Merged

fix(datepicker): cursor fixes for disabled dates & weeks in datepicker #4905

merged 1 commit into from
Dec 7, 2018

Conversation

daniloff200
Copy link
Contributor

@daniloff200 daniloff200 commented Dec 7, 2018

PR Checklist

Before creating new PR, please take a look at checklist below to make sure that you've done everything that needs to be done before we can merge it.

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated tests.
  • added/updated API documentation.
  • added/updated demos.

@ghost ghost added the needs review label Dec 7, 2018
@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #4905 into development will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #4905      +/-   ##
===============================================
+ Coverage        74.51%   74.59%   +0.08%     
===============================================
  Files              273      273              
  Lines             8365     8365              
  Branches          1594     1594              
===============================================
+ Hits              6233     6240       +7     
+ Misses            1696     1688       -8     
- Partials           436      437       +1
Impacted Files Coverage Δ
src/chronos/i18n/pl.ts 69.23% <0%> (-2.57%) ⬇️
src/datepicker/reducer/bs-datepicker.effects.ts 72.47% <0%> (-1.84%) ⬇️
src/chronos/i18n/cs.ts 84.74% <0%> (ø) ⬆️
src/chronos/i18n/sk.ts 80.85% <0%> (ø) ⬆️
src/typeahead/typeahead.directive.ts 74.86% <0%> (+1.04%) ⬆️
src/component-loader/component-loader.class.ts 76.25% <0%> (+2.15%) ⬆️
src/utils/triggers.ts 70% <0%> (+5%) ⬆️
src/datepicker/engine/flag-days-calendar.ts 80% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc77f8...4af7ea4. Read the comment docs.

@codecov
Copy link

codecov bot commented Dec 7, 2018

Codecov Report

Merging #4905 into development will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff               @@
##           development   #4905      +/-   ##
==============================================
+ Coverage        74.63%   74.7%   +0.07%     
==============================================
  Files              276     276              
  Lines             8385    8385              
  Branches          1594    1594              
==============================================
+ Hits              6258    6264       +6     
+ Misses            1687    1680       -7     
- Partials           440     441       +1
Impacted Files Coverage Δ
src/component-loader/component-loader.class.ts 76.25% <0%> (+2.15%) ⬆️
src/utils/triggers.ts 70% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6e3534...c029789. Read the comment docs.

Domainv
Domainv previously approved these changes Dec 7, 2018
src/datepicker/bs-datepicker.scss Outdated Show resolved Hide resolved
@ludmilanesvitiy
Copy link
Contributor

Nice to have: remove cursor-pointer from weekdays on the left column also

EvilAlexei
EvilAlexei previously approved these changes Dec 7, 2018
@daniloff200 daniloff200 changed the title fix(datepicker): cursor fixes for some cases fix(datepicker): cursor fixes for disabled dates & weeks in datepicker Dec 7, 2018
@ludmilanesvitiy
Copy link
Contributor

@daniloff200 Thank you! Well done. Tested in Chrome, FF, IE - looks pretty good)

@valorkin valorkin merged commit 5c0efdd into valor-software:development Dec 7, 2018
@ghost ghost removed the ready for merge label Dec 7, 2018
@daniloff200 daniloff200 deleted the cursor-fixes branch December 7, 2018 12:32
@valorkin valorkin added this to the 3.1.4 milestone Dec 12, 2018
leo6104 pushed a commit to leo6104/ngx-bootstrap that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants