Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use custom deepmerge() #27

Merged
merged 3 commits into from May 13, 2019
Merged

fix: use custom deepmerge() #27

merged 3 commits into from May 13, 2019

Conversation

unional
Copy link
Owner

@unional unional commented May 13, 2019

deepmerge does not work with class instance.

Create an internal implementation (not pretty) that fixes this issue.

`deepmerge` does not work with class instance.

Create an internal implementation (not pretty) that fixes this issue.
@codecov-io
Copy link

codecov-io commented May 13, 2019

Codecov Report

Merging #27 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #27   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines          14     25   +11     
  Branches        1      9    +8     
=====================================
+ Hits           14     25   +11
Impacted Files Coverage Δ
src/required.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11d3a41...394ec61. Read the comment docs.

@coveralls
Copy link

coveralls commented May 13, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 394ec61 on new-merge into 11d3a41 on master.

@unional unional merged commit 093621b into master May 13, 2019
@unional
Copy link
Owner Author

unional commented May 13, 2019

🎉 This PR is included in version 0.6.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants