Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eslint-plugin): [no-type-alias] handle conditional types #953

Merged
merged 6 commits into from Nov 14, 2019

Conversation

otofu-square
Copy link
Contributor

Fixes #949

  • add allowConditionalTypes option to no-type-alias rule
  • test
  • docs

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @otofu-square!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint

@bradzacher bradzacher added the enhancement: plugin rule option New rule option for an existing eslint-plugin rule label Sep 6, 2019
bradzacher
bradzacher previously approved these changes Nov 14, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #953 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
+ Coverage   94.14%   94.14%   +<.01%     
==========================================
  Files         124      124              
  Lines        5330     5333       +3     
  Branches     1489     1491       +2     
==========================================
+ Hits         5018     5021       +3     
  Misses        178      178              
  Partials      134      134
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/no-type-alias.ts 95.08% <100%> (+0.25%) ⬆️

bradzacher
bradzacher previously approved these changes Nov 14, 2019
@bradzacher bradzacher changed the title feat(eslint-plugin): [no-type-alias] handle conditional types in no-type-alias rule feat(eslint-plugin): [no-type-alias] handle conditional types Nov 14, 2019
@bradzacher bradzacher merged commit 259ff20 into typescript-eslint:master Nov 14, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement: plugin rule option New rule option for an existing eslint-plugin rule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-type-alias] Conditional types are unhandled
2 participants