feat(eslint-plugin): add space-before-function-paren [extension] #924
Conversation
|
Thanks for the PR, @Austaras! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint |
Codecov Report
@@ Coverage Diff @@
## master #924 +/- ##
=========================================
+ Coverage 94.05% 94.1% +0.04%
=========================================
Files 123 124 +1
Lines 5286 5325 +39
Branches 1470 1487 +17
=========================================
+ Hits 4972 5011 +39
Misses 179 179
Partials 135 135
|
bradzacher
added
the
enhancement: new base rule extension
|
@bradzacher may you or other member take some time review this and get it merged? |
| export type Options = [ | ||
|
|
||
| | Option |
There was a problem hiding this comment.
nit formatting - this was a bug in prettier that's since been fixed
There was a problem hiding this comment.
maybe you should update prettier in yarn.lock first or test for format will fail
bradzacher
added
1 approval
|
still formatting errors in the file - if you can run prettier on the file to get the CI passing, we can look to merge this. |
|
It should. If I guess correctly, CI is using prettier 1.18.2 in yarn.lock but your requested change could only satisfy format for prettier 1.19 |
|
oh wow. I'm sorry - I didn't realise we hadn't updated the prettier version. |
bradzacher
removed
the
awaiting response
The new rule `@typescript-eslint/space-before-function-paren` has been added since `@typescript-eslint/eslint-plugin@2.8.0`. - https://github.com/typescript-eslint/typescript-eslint/blob/v2.8.0/packages/eslint-plugin/docs/rules/space-before-function-paren.md - https://github.com/typescript-eslint/typescript-eslint/releases/tag/v2.8.0 - typescript-eslint/typescript-eslint#924 This rule is an extension of the ESLint core rule `space-before-function-paren`, and `eslint-config-prettier` has disabled the rule already. - https://github.com/prettier/eslint-config-prettier/blob/ed97c2f4cb77b5cc8cb941900b81304b5cd6eb1d/index.js#L77
"Half fixes" #707