fix(typescript-estree): options range loc being always true

[Mark1626]

Fix #694

@bradzacher

Originally planned on removing range and loc inside here

typescript-eslint/packages/typescript-estree/src/convert.ts

Lines 207 to 210 in c2ad091

	private createNode<T extends TSESTree.BaseNode = TSESTree.BaseNode>(
	node: ts.Node,
	data: TSESTree.OptionalRangeAndLoc<T>,
	): T {

but saw that some Nodes(StringLiteral, BigIntLiteral) depended on range after createNode.

Left the responsibility of removing it to

typescript-eslint/packages/typescript-estree/src/convert.ts

Lines 83 to 88 in c2ad091

	private converter(
	node?: ts.Node,
	parent?: ts.Node,
	inTypeMode?: boolean,
	allowPattern?: boolean,
	): any {

which covered all Nodes except ClassDeclaration, InterfaceDeclaration, ShorthandPropertyAssignment on which I had to remove the field if necessary

Let me know if I need to change anything

[bradzacher]

I don't think there's a problem with the idea behind your logic, but I think that it'll be a bit hard on the maintenance side.

We will have to ensure that we remember to catch every single place that creates a child node outside of the normal converter flow, and call applyExtraOptions to it.

This is very manual and will be error prone. For example in this diff, it looks like you missed the usages in convertJSXTagName.

I think a better option would be to do this after the AST has been created in its entirety.

Within the parser package, we have a list of visitor keys. Additionally, we have a utility class, SimpleTraverser, which you can use to traverse the AST.

These two could be moved into typescript-estree, and used to traverse the tree after the fact, and scrub the range/loc if requested:

function parse(file, options) {
  const ast = convert();
  if (options.range === false || options.loc === false) {
    const traverser = new SimpleTraverser({
      enter() => // scrub range and/or loc
    })
    traverser.traverse(ast);
  }
}

WDYT?

[Mark1626]

Sure I think it's better to do this after the AST has been created. I'll make the changes

[codecov]

Codecov Report

Merging #704 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #704      +/-   ##
==========================================
+ Coverage   93.98%   93.98%   +<.01%     
==========================================
  Files         121      121              
  Lines        5217     5224       +7     
  Branches     1444     1447       +3     
==========================================
+ Hits         4903     4910       +7     
  Misses        179      179              
  Partials      135      135

Impacted Files	Coverage Δ
packages/parser/src/parser.ts	100% <ø> (ø)	⬆️
packages/typescript-estree/src/visitor-keys.ts	100% <ø> (ø)
packages/typescript-estree/src/simple-traverse.ts	95% <ø> (ø)
packages/typescript-estree/src/ast-converter.ts	100% <100%> (ø)	⬆️
packages/parser/src/analyze-scope.ts	95.5% <100%> (ø)	⬆️
packages/typescript-estree/src/parser.ts	94.06% <100%> (+0.1%)	⬆️

[bradzacher]

LGTM! Thanks for doing this