New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(eslint-plugin): added new rule prefer-readonly #555
Merged
bradzacher
merged 10 commits into
typescript-eslint:master
from
JoshuaKGoldberg:prefer-readonly
Jun 24, 2019
Merged
feat(eslint-plugin): added new rule prefer-readonly #555
bradzacher
merged 10 commits into
typescript-eslint:master
from
JoshuaKGoldberg:prefer-readonly
Jun 24, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the equivalent of TSLint's `prefer-readonly` rule.
Codecov Report
@@ Coverage Diff @@
## master #555 +/- ##
=========================================
+ Coverage 94.22% 94.3% +0.07%
=========================================
Files 108 109 +1
Lines 4419 4533 +114
Branches 1217 1253 +36
=========================================
+ Hits 4164 4275 +111
- Misses 147 148 +1
- Partials 108 110 +2
|
bradzacher
added
the
enhancement: new plugin rule
New rule request for eslint-plugin
label
May 28, 2019
bradzacher
requested changes
Jun 1, 2019
great work! |
JamesHenry
approved these changes
Jun 23, 2019
JamesHenry
added
the
1 approval
PR that a maintainer has LGTM'd - any maintainer can merge this when ready
label
Jun 23, 2019
bradzacher
approved these changes
Jun 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
1 approval
PR that a maintainer has LGTM'd - any maintainer can merge this when ready
enhancement: new plugin rule
New rule request for eslint-plugin
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the equivalent of TSLint's
prefer-readonly
rule.Edit: will fix up post merge soon...!✔️