fix(eslint-plugin): no-object-literal-type-assertion: fix as const
is reported
#390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166
as const
was added at TypeScript 3.4.1 andno-object-literal-type-assertion
detects it. Howeveras const
is a special syntax and the rule should not report it as error.I'm not sure this fix is proper. We might need to add new
TSConstType
node likeTSThisType
sinceas const
is different syntax from type assertion. But for now, TypeScript 3.4 was released as stable release and I want this fix as first aid.