fix(eslint-plugin) indent: fix false positive on type parameters #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
As noted in #119, the following code was triggering the indent rule:
...but the following, almost identical, code was not:
The difference, it seems, is the type parameter:
<HTMLElement>
.Comparing the two ASTs, I notice a node type that was not included in the
KNOWN_NODES
set:TSTypeParameterInstantiation
.Without fully understanding the inner workings of the
indent
rule, I simply added this missing node type to the set; and sure enough it seems to have fixed the false positive.I've added test cases for the valid code samples and confirmed that the tests still pass; but I'm unsure of any other impact from adding this additional node type to the set of known nodes.