Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [dot-notation] fix typo in schema #2040

Merged
merged 1 commit into from May 18, 2020
Merged

fix(eslint-plugin): [dot-notation] fix typo in schema #2040

merged 1 commit into from May 18, 2020

Conversation

andrefilimono
Copy link
Contributor

@andrefilimono andrefilimono commented May 18, 2020

fixes #2042

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @andrefilimono!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@andrefilimono andrefilimono changed the title fix(eslint-plugin): fix typo in schema fix(eslint-plugin): [dot-notation] fix typo in schema May 18, 2020
@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #2040 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2040   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files         172      172           
  Lines        7843     7843           
  Branches     2253     2253           
=======================================
  Hits         7366     7366           
  Misses        217      217           
  Partials      260      260           
Flag Coverage Δ
#unittest 93.91% <ø> (ø)
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/dot-notation.ts 86.66% <ø> (ø)

@bradzacher bradzacher added the bug Something isn't working label May 18, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher merged commit 242328f into typescript-eslint:master May 18, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

typo in tyoe should be type
2 participants