Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(typescript-estree): make FunctionDeclaration.body non-null #1288

Merged
merged 1 commit into from Nov 30, 2019
Merged

fix(typescript-estree): make FunctionDeclaration.body non-null #1288

merged 1 commit into from Nov 30, 2019

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Nov 30, 2019

This is half of #734:

I didn't realise it, but in #156, it added handling to convert function declarations with no body into TSFunctionDeclaration (https://github.com/typescript-eslint/typescript-eslint/pull/156/files#diff-68b2b0b0d2d0ff1846b1114472008332R674)

So it looks like there's no case now that a FunctionDeclaration can have no body?

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @G-Rath!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher changed the title fix(ts-estree): mark body of FunctionDeclaration not null fix(typescript-estree): FunctionDeclaration.body should be non-nullable Nov 30, 2019
@bradzacher bradzacher added the bug Something isn't working label Nov 30, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for doing this!

@bradzacher bradzacher changed the title fix(typescript-estree): FunctionDeclaration.body should be non-nullable fix(typescript-estree): make FunctionDeclaration.body non-null Nov 30, 2019
@bradzacher bradzacher merged commit dc73510 into typescript-eslint:master Nov 30, 2019
@G-Rath
Copy link
Contributor Author

G-Rath commented Nov 30, 2019

No problem - I've almost finished doing the second half, which I'll push up in a few minutes for review.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants