Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unused-expressions] ignore directives #1285

Conversation

a-tarasyuk
Copy link
Contributor

@a-tarasyuk a-tarasyuk commented Nov 29, 2019

Fixes #1283

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 29, 2019

Codecov Report

Merging #1285 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1285      +/-   ##
==========================================
+ Coverage   94.06%   94.06%   +<.01%     
==========================================
  Files         131      131              
  Lines        5745     5746       +1     
  Branches     1617     1618       +1     
==========================================
+ Hits         5404     5405       +1     
  Misses        183      183              
  Partials      158      158
Impacted Files Coverage Δ
...s/eslint-plugin/src/rules/no-unused-expressions.ts 100% <100%> (ø) ⬆️

@bradzacher bradzacher added the bug Something isn't working label Nov 29, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-unused-expressions] directive detection does not work on modules
2 participants