Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [strict-bool-expr] allow nullish coalescing #1275

Merged
merged 1 commit into from Nov 28, 2019

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented Nov 27, 2019

This rule shouldn't actually touch them, but it never checked the operator, so it does right now..

@bradzacher bradzacher added the bug Something isn't working label Nov 27, 2019
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@bradzacher bradzacher merged commit 3b39340 into master Nov 28, 2019
@bradzacher bradzacher deleted the strict-bool-nullish-coalesce branch November 28, 2019 00:29
@ShayDavidson
Copy link

ShayDavidson commented Nov 28, 2019

Thanks for this! 🙏 This has been the only blocker for me for using null coalescing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants