Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnec-type-arg] throwing on call/new expr #1217

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1076

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 17, 2019

Codecov Report

Merging #1217 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1217      +/-   ##
==========================================
+ Coverage   94.17%   94.17%   +<.01%     
==========================================
  Files         124      124              
  Lines        5320     5322       +2     
  Branches     1491     1492       +1     
==========================================
+ Hits         5010     5012       +2     
  Misses        177      177              
  Partials      133      133
Impacted Files Coverage Δ
...-plugin/src/rules/no-unnecessary-type-arguments.ts 92% <100%> (+0.33%) ⬆️

@bradzacher
Copy link
Member

One change - otherwise LGTM. Thanks

Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks

@bradzacher bradzacher added the bug Something isn't working label Nov 17, 2019
@bradzacher bradzacher changed the title fix(eslint-plugin): [no-unnecessary-type-arguments] throws fix(eslint-plugin): [no-unnec-type-arg] throwing on call/new expr Nov 17, 2019
@bradzacher bradzacher merged commit 42a48de into typescript-eslint:master Nov 17, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-unnecessary-type-arguments] throws
2 participants