Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-type-alias] handle constructor aliases #1198

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1191

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #1198 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1198      +/-   ##
==========================================
+ Coverage   94.05%   94.05%   +<.01%     
==========================================
  Files         123      123              
  Lines        5283     5286       +3     
  Branches     1468     1470       +2     
==========================================
+ Hits         4969     4972       +3     
  Misses        179      179              
  Partials      135      135
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/no-type-alias.ts 94.82% <100%> (+0.28%) ⬆️

@bradzacher bradzacher added the bug Something isn't working label Nov 12, 2019
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this

@bradzacher bradzacher merged commit 1bb4d63 into typescript-eslint:master Nov 12, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-type-alias] False positive with constructor aliases
2 participants