fix(eslint-plugin): [require-await] better handle nesting #1193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1188
The extension knows the inner callback doesn't need have an error, so it doesn't call the base rule's handler. But in doing so, it means the base rule doesn't properly update its internal state, so it ends up looking at the state for the cb whilst exiting testFunction.
This fixes the rule so that instead of not calling the base rule, it uses the rule's logic to update the rule's internal state, which prevents the base rule logic from erroring.