Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): crash fixing readonly arrays to generic #1172

Conversation

a-tarasyuk
Copy link
Contributor

Fixes #1149

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @a-tarasyuk!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@a-tarasyuk a-tarasyuk force-pushed the bug/1149-eslint-crashes-when-try-to-fix-readonly-arrays-to-generic branch from 90a28b3 to dc2672e Compare November 5, 2019 13:52
@codecov
Copy link

codecov bot commented Nov 5, 2019

Codecov Report

Merging #1172 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1172      +/-   ##
==========================================
+ Coverage   93.98%   93.99%   +0.01%     
==========================================
  Files         120      120              
  Lines        5185     5195      +10     
  Branches     1438     1440       +2     
==========================================
+ Hits         4873     4883      +10     
  Misses        178      178              
  Partials      134      134
Impacted Files Coverage Δ
packages/eslint-plugin/src/rules/array-type.ts 93.33% <100%> (+0.7%) ⬆️

@a-tarasyuk a-tarasyuk force-pushed the bug/1149-eslint-crashes-when-try-to-fix-readonly-arrays-to-generic branch from dc2672e to 6573112 Compare November 5, 2019 14:11
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this.

@bradzacher bradzacher changed the title fix(eslint-plugin): crashes when try to fix readonly arrays to generic fix(eslint-plugin): crash fixing readonly arrays to generic Nov 5, 2019
@bradzacher bradzacher merged commit 2b2f2d7 into typescript-eslint:master Nov 5, 2019
@bradzacher bradzacher added the bug Something isn't working label Nov 5, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[array-type] eslint crashes when try to fix readonly arrays to generic
2 participants