fix(eslint-plugin): [prefer-optional-chain] allow $ in identifiers

typescript-eslint · Nov 27, 2019 · c72c3c1 · c72c3c1
1 parent f83f04b
commit c72c3c1
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/prefer-optional-chain.ts b/packages/eslint-plugin/src/rules/prefer-optional-chain.ts
@@ -95,7 +95,7 @@ export default util.createRule({
             `^${
               // escape regex characters
               leftText.replace(/[.*+?^${}()|[\]\\]/g, '\\$&')
-            }[^a-zA-Z0-9_]`,
+            }[^a-zA-Z0-9_$]`,
           );
           if (
             !matchRegex.test(rightText) &&

diff --git a/packages/eslint-plugin/tests/rules/prefer-optional-chain.test.ts b/packages/eslint-plugin/tests/rules/prefer-optional-chain.test.ts
@@ -126,6 +126,7 @@ ruleTester.run('prefer-optional-chain', rule, {
     'nextToken && sourceCode.isSpaceBetweenTokens(prevToken, nextToken)',
     'result && this.options.shouldPreserveNodeMaps',
     'foo && fooBar.baz',
+    'match && match$1 !== undefined',
     'foo !== null && foo !== undefined',
     'x["y"] !== undefined && x["y"] !== null',
     // currently do not handle complex computed properties