- Minor refactoring: Remove options check in npm.js' `defaultPref…

…ix` function as function does not later allow a non-object anyways - Minor refactoring: Avoid else after throw
raineorshine · Oct 6, 2019 · 6b030b8 · 6b030b8
1 parent b84dd92
commit 6b030b8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/package-managers/npm.js b/lib/package-managers/npm.js
@@ -114,7 +114,7 @@ function spawnNpm(args, npmOptions={}, spawnOptions={}) {
 */
 function defaultPrefix(options) {
 
-    if (options && options.prefix) {
+    if (options.prefix) {
         return Promise.resolve(options.prefix);
     }
 

diff --git a/lib/version-util.js b/lib/version-util.js
@@ -55,7 +55,8 @@ function precisionAdd(precision, n) {
 
     if (index === null) {
         throw new Error(`Invalid precision: ${precision}`);
-    } else if (!VERSION_PARTS[index]) {
+    }
+    if (!VERSION_PARTS[index]) {
         throw new Error(`Invalid precision math${arguments}`);
     }