Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable setting DEFAULT_INTERVAL and DEFAULT_TIMEOUT for wait* methods #648

Open
michens opened this issue Jul 9, 2021 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@michens
Copy link

michens commented Jul 9, 2021

Describe the feature you'd like:

The wait* methods take optional interval and timeout values, and fall back to hard coded defaults if not set.
I would like for the defaults to be configurable.
It's straightforward to wrap the methods, so this is certainly not critical, but I think it would be nice

Suggested implementation:

Add a setDefaultWaitOptions method that can update the options that the wait* methods fall back to

Describe alternatives you've considered:

There could be a way to read from a config file on environment.
Maybe it would be better to have separate methods for setting them.
If desired, a stack could be implemented to push/pop settings for regions to have different defaults.
I really don't think it needs to be this complicated though

Teachability, Documentation, Adoption, Migration Strategy:

Users would be able to call the function in a setup file and then use the wait* functions normally, but with updated settings

@michens michens added the enhancement New feature or request label Jul 9, 2021
@mpeyper
Copy link
Member

mpeyper commented Jul 11, 2021

I'm not opposed to this idea. Is it something you'd like to work on and submit a PR for?

@michens
Copy link
Author

michens commented Jul 26, 2021

Finally got a chance to take a look at this and make a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants