Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undocumented queries #223

Closed
kentcdodds opened this issue Mar 19, 2019 · 3 comments
Closed

Remove undocumented queries #223

kentcdodds opened this issue Mar 19, 2019 · 3 comments
Labels
BREAKING CHANGE This change will require a major version bump released

Comments

@kentcdodds
Copy link
Member

Like:

  • BySelectText
  • ByValue

Those two are now handled via ByDisplayValue 馃憤

This will be a breaking change. And I'm working on it today hopefully.

@kentcdodds kentcdodds added the BREAKING CHANGE This change will require a major version bump label Mar 19, 2019
kentcdodds pushed a commit that referenced this issue Mar 19, 2019
Closes #223

BREAKING CHANGE: This removes the deprecated queries `ByValue` and `BySelectText`. Use `ByDisplayValue` instead.
kentcdodds pushed a commit that referenced this issue Mar 19, 2019
Closes #223

BREAKING CHANGE: This removes the deprecated queries `ByValue` and `BySelectText`. Use `ByDisplayValue` instead.
kentcdodds pushed a commit that referenced this issue Mar 20, 2019
Closes #223

BREAKING CHANGE: This removes the deprecated queries `ByValue` and `BySelectText`. Use `ByDisplayValue` instead.
kentcdodds pushed a commit that referenced this issue Mar 20, 2019
Closes #223

BREAKING CHANGE: This removes the deprecated queries `ByValue` and `BySelectText`. Use `ByDisplayValue` instead.
@huchenme
Copy link

May I know where can I find documentation for all methods listed here? https://github.com/kentcdodds/dom-testing-library/blob/master/src/queries.js

@kentcdodds
Copy link
Member Author

kentcdodds pushed a commit that referenced this issue Apr 17, 2019
Closes #223

BREAKING CHANGE: This removes the deprecated queries `ByValue` and `BySelectText`. Use `ByDisplayValue` instead.
kentcdodds pushed a commit that referenced this issue Apr 25, 2019
Closes #223

BREAKING CHANGE: This removes the deprecated queries `ByValue` and `BySelectText`. Use `ByDisplayValue` instead.
@kentcdodds
Copy link
Member Author

馃帀 This issue has been resolved in version 4.0.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump released
Projects
None yet
Development

No branches or pull requests

2 participants