Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example with Karma? #161

Closed
kentcdodds opened this issue Nov 25, 2018 · 4 comments
Closed

Example with Karma? #161

kentcdodds opened this issue Nov 25, 2018 · 4 comments
Labels
documentation An update needs to be made to documentation

Comments

@kentcdodds
Copy link
Member

Some people can't use Jest because they either want to run their tests in a real browser or jsdom doesn't support something their framework uses (like web components).

I think it'd be great to have a repository to point to that shows how to use dom-testing-library with Karma. I think it'd be sweet if the example tests components made with lit-html :)
@LarsDenBakker
Copy link

We are working karma web component example configs here open-wc/open-wc#58. Ill make sure to add an example with this library.

@kentcdodds
Copy link
Member Author

Cool thanks! Could you add a link to the README here when you're finished?

@alexkrolick alexkrolick added the documentation An update needs to be made to documentation label Dec 9, 2018
@kentcdodds
Copy link
Member Author

@LarsDenBakker, any updates?

@kentcdodds
Copy link
Member Author

Closing this for inactivity. If someone wants to work on it in the future feel free to open a new issue. Thanks!

@Westbrook Westbrook mentioned this issue Jan 8, 2020
Open
Westbrook added a commit to Westbrook/dom-testing-library that referenced this issue Jan 27, 2020
@Westbrook
Ensure 'process' is available before using
87df57a 
refs testing-library#413 
refs testing-library#161 

Not all environments (particularly the browser, where testing via tools like Karma occurs) have access to the `process` variable. There is already checking to ensure that its member properties have fallbacks, and this ensures that if it is simply unavailable the same fallback occurs.
@Westbrook Westbrook mentioned this issue Jan 27, 2020
Merged
4 tasks
kentcdodds pushed a commit that referenced this issue Jan 28, 2020
@Westbrook
fix: ensure 'process' is available before using (#431)
905f4b3 
refs #413 
refs #161 

Not all environments (particularly the browser, where testing via tools like Karma occurs) have access to the `process` variable. There is already checking to ensure that its member properties have fallbacks, and this ensures that if it is simply unavailable the same fallback occurs.
@tamlyn tamlyn mentioned this issue May 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation An update needs to be made to documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kentcdodds @alexkrolick @LarsDenBakker