Expose the uncaughtException handler better

Partly addresses #475, albeit via a somewhat hacky workaround.
tapjs · Jan 22, 2019 · f2f0746 · f2f0746
1 parent cf8a2e1
commit f2f0746
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 8 deletions.
diff --git a/lib/tap.js b/lib/tap.js
@@ -66,7 +66,7 @@ class TAP extends Test {
   patchProcess () {
     monkeypatchEpipe()
     monkeypatchExit()
-    process.on('uncaughtException', this.threw)
+    process.on('uncaughtException', er => this.threw(er))
     process.on('unhandledRejection', er => this.threw(er))
   }
 

diff --git a/tap-snapshots/test-tap.js-TAP.test.js b/tap-snapshots/test-tap.js-TAP.test.js
@@ -213,31 +213,34 @@ Error: poop
 
 `
 
-exports[`test/tap.js TAP process.exitCode polyfill > exit status 1`] = `
+exports[`test/tap.js TAP uncaught exception > exit status 1`] = `
 { code: 1, signal: null }
 `
 
-exports[`test/tap.js TAP process.exitCode polyfill > stdout 1`] = `
+exports[`test/tap.js TAP uncaught exception > stdout 1`] = `
 TAP version 13
-not ok 1 - v0.10.420
+ok 1 - this is fine
+ok 2 - i am sure things are ok
+not ok 3 - poop
   ---
   at:
     line: #
     column: #
     file: test/tap.js
   source: |
-    t.fail(process.version)
+    setTimeout(() => { throw new Error('poop') })
   stack: |
     {STACK}
+  test: TAP
   ...
 
-1..1
-# failed 1 test
+1..3
+# failed 1 of 3 tests
 # {time}
 
 `
 
-exports[`test/tap.js TAP process.exitCode polyfill > stderr 1`] = `
+exports[`test/tap.js TAP uncaught exception > stderr 1`] = `
 
 `
 

diff --git a/test/tap.js b/test/tap.js
@@ -38,6 +38,11 @@ const cases = {
     t.on('teardown', () => { throw new Error('poop') })
     t.pass('x')
   },
+  'uncaught exception': t => {
+    t.pass('this is fine')
+    setTimeout(() => { throw new Error('poop') })
+    t.pass('i am sure things are ok')
+  },
   'TAP_DEBUG=1': [
     () => process.env.TAP_DEBUG = '1',
     t => t.comment('this is fine')