Remove some tests of things that can't be done in v11+

lib/tap.js

@@ -7,6 +7,9 @@ const objToYaml = require('./obj-to-yaml.js')
 const yaml = require('js-yaml')
 const _didPipe = Symbol('_didPipe')
 
+// We test that file separately, and removing stdout
+// causes some weird behavior in the Node test runner.
+/* istanbul ignore next */
 if (!process.stdout) {
   require('./stdio-polyfill')()
 }
@@ -25,6 +28,7 @@ const monkeypatchExit = () => {
 
   // ensure that we always get run, even if a user does
   // process.on('exit', process.exit)
+  /* istanbul ignore next */
   process.reallyExit = code =>
     reallyExit.call(process, onExitEvent(code))
 
@@ -100,7 +104,7 @@ class TAP extends Test {
 let didOnExitEvent = false
 const onExitEvent = code => {
   if (didOnExitEvent)
-    return process.exitCode || code
+    return process.exitCode
 
   didOnExitEvent = true
 
@@ -109,6 +113,8 @@ const onExitEvent = code => {
 
   if (tap.results && !tap.results.ok && code === 0) {
     process.exitCode = 1
+    // We don't test with these any more.  They don't work much anyway.
+    /* istanbul ignore next */
     if (process.version.match(/^v0\.(10|[0-9])\./))
       process.exit(code)
   }
@@ -181,6 +187,9 @@ onExit((code, signal) => {
       return ret
     })
   }
+
+  // Newer node versions don't have this as reliably.
+  /* istanbul ignore next */
   if (handles.length) {
     extra.handles = handles.map(h => {
       const ret = {}

test/tap.js

@@ -38,10 +38,6 @@ const cases = {
     t.on('teardown', () => { throw new Error('poop') })
     t.pass('x')
   },
-  'process.exitCode polyfill': t => {
-    Object.defineProperty(process, 'version', { value: 'v0.10.420' })
-    t.fail(process.version)
-  },
   'TAP_DEBUG=1': [
     () => process.env.TAP_DEBUG = '1',
     t => t.comment('this is fine')