New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript: support sweetalert2 modules in dist and src folders #1693
Conversation
Pull Request Test Coverage Report for Build 5245
💛 - Coveralls |
Hah, it's a nice idea to use globs in the .d.ts file to cover both src and dist! |
a9e19c6
to
80bd6d8
Compare
Yup, wildcards are working nicely, I also tried declare module 'sweetalert2/*/sweetalert2.*js' { to avoid copy-pasting, but
Thanks again @toverux for your valuable (as always) input! |
## [8.14.1](v8.14.0...v8.14.1) (2019-08-02) ### Bug Fixes * **types:** support sweetalert2 modules from dist and src folders ([#1693](#1693)) ([ca1cbe9](ca1cbe9))
🎉 This PR is included in version 8.14.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Fixing the issue I described in https://stackoverflow.com/questions/57321486
TLDR: right now
import Swal from 'sweetalert2/dist/sweetalert2.js'
isn't TS-friendly and producing this error:This PR is based on @toverux's answer https://stackoverflow.com/a/57323500