Fix false negatives for ignore: ["inside-block"] in rule-empty-line-before #2894
Conversation
| @@ -5,6 +5,9 @@ | |||
| h1 { | |||
There was a problem hiding this comment.
Would the following?
@media (min-width: 100px) {
h1 {
font-weight: normal;
}
}And no warnings be a more appropriate test for this change as your fixing false positives, right?
There was a problem hiding this comment.
Would the following?
It has nothing to do with this.
The affected is that the <style> tag first-level child element is misjudged as nested.
And no warnings be a more appropriate test for this change as your fixing false positives, right?
It is not "false positives", It is "missed warnings"
(I don't know if my English is appropriate, title modified, please help correct English grammar)
There was a problem hiding this comment.
The affected is that the <style> tag first-level child element is misjudged as nested.
Oooo, I see now. Sorry, I misunderstood.
It is not "false positives", It is "missed warnings"
I've just been using "false negatives" for those :)
gucong3000
changed the title
jeddy3
changed the title
| expect(ruleEmptyLineBeforeResult.warnings.length).toBe(0); | ||
| expect(ruleEmptyLineBeforeResult.errored).toBe(true); | ||
| expect(ruleEmptyLineBeforeResult.warnings.length).toBe(1); | ||
| expect(ruleEmptyLineBeforeResult.warnings[0].line).toBe(8); |
There was a problem hiding this comment.
What are the 8 warnings added in this change?
There was a problem hiding this comment.
Not 8 warnings, just 1. 8 is line number.
|
#2891
No, it's self explanatory.