Fix support for *-empty-line-before in HTML #2854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,7 +59,7 @@ const rule = function(expectation, options, context) { | |||
| const isNested = atRule.parent !== root; | |||
|
|
|||
| // Ignore the first node | |||
| if (atRule === root.first) { | |||
| if (atRule === root.first || atRule === atRule.root().first) { | |||
There was a problem hiding this comment.
Please add comment around atRule === atRule.root().first and good work!
jeddy3
requested changes
Sep 10, 2017
There was a problem hiding this comment.
@gucong3000 Thanks - tests look great. I've made a request out creating a util.
| @@ -51,8 +51,12 @@ const rule = function(expectation, options, context) { | |||
| return; | |||
| } | |||
|
|
|||
| // Ignore the first node | |||
| if (rule === root.first) { | |||
| if ( | |||
There was a problem hiding this comment.
Can we please move this into a util, e.g. isFirstNodeOfRoot(node) as I suspect other rules will need too.
jeddy3
changed the title
jeddy3
reviewed
Sep 11, 2017
There was a problem hiding this comment.
@gucong3000 Thanks for making the util change. I've added one query.
| @@ -52,7 +53,7 @@ const rule = function(expectation, options, context) { | |||
| } | |||
|
|
|||
| // Ignore the first node | |||
| if (rule === root.first) { | |||
| if (isFirstNodeOfRoot(rule, root)) { | |||
There was a problem hiding this comment.
Did you mean to pass root in as a second parameter?
|
This was referenced Mar 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2853
"No, it's self explanatory."