New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix webpack config file name for react-scripts > 2.1.1 #1241
Conversation
Codecov Report
|
Please have a look at the CI results. |
@sapegin The build passed before I add tests. I m not sure how unit tests can breaks integration tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restart helps with that usually ;-)
} | ||
return a; | ||
}); | ||
expect(result).toMatch(/^react-scripts\/config\/webpack\.config/); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also match webpack.config.dev
. Probably should be something like /^react-scripts\/config\/webpack\.config.js$/
.
Looks like there's no JS at the end. Actually, since it's not a real
|
Didn't know about |
Since react-scripts 2.1.1, the config file is named webpack.config.js instead of webpack.config.dev.js.