Skip to content

Commit

Permalink
fix(dispose): fix raise condition in dispose action
Browse files Browse the repository at this point in the history
Fix a raise condition during disposing of our resources. Now using [typed-inject's dispose functionality](https://github.com/nicojs/typed-inject/#-disposing-provided-stuff)

Fixes #1542
  • Loading branch information
nicojs committed Jul 11, 2019
1 parent 4349867 commit 124ef6a
Show file tree
Hide file tree
Showing 23 changed files with 184 additions and 106 deletions.
2 changes: 1 addition & 1 deletion e2e/helpers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export async function expectMetricsResult(expectedMetricsResult: Partial<Metrics
const actualMetricsResult = await readMutationTestResult();
const actualSnippet: Partial<WritableMetricsResult> = {};
for (const key in expectedMetricsResult) {
actualSnippet[key as keyof MetricsResult] = actualMetricsResult[key as keyof MetricsResult];
actualSnippet[key as keyof MetricsResult] = actualMetricsResult[key as keyof MetricsResult] as any;
}
if (actualSnippet.metrics) {
if (typeof actualSnippet.metrics.mutationScore === 'number') {
Expand Down
56 changes: 33 additions & 23 deletions e2e/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion e2e/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
"rxjs": "^6.3.3",
"semver": "^5.6.0",
"ts-node": "~7.0.0",
"typescript": "~2.9.2",
"typescript": "~3.5.1",
"webpack": "~4.16.0"
},
"scripts": {
Expand Down

0 comments on commit 124ef6a

Please sign in to comment.