Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

addon-storyshots-puppeteer: fix peerDependencies #4828

Merged
merged 1 commit into from Nov 23, 2018
Merged

addon-storyshots-puppeteer: fix peerDependencies #4828

merged 1 commit into from Nov 23, 2018

Conversation

bertho-zero
Copy link
Contributor

No description provided.

@storybook-safe-bot
Copy link
Contributor

Fails
🚫

PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","dependencies:update","dependencies","other"]

Generated by 🚫 dangerJS

shilman
shilman approved these changes Nov 23, 2018
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@shilman shilman merged commit 4bd15a8 into storybookjs:master Nov 23, 2018
@shilman shilman added patch:yes Bugfix & documentation PR that need to be picked to main branch patch:done Patch/release PRs already cherry-picked to main/release branch labels Nov 23, 2018
shilman added a commit that referenced this pull request Nov 23, 2018
@shilman
Merge pull request #4828 from bertho-zero/patch-1
9bdd2fb 
addon-storyshots-puppeteer: fix peerDependencies
@shilman shilman removed the bug label Nov 25, 2018
This was referenced Dec 1, 2018
Closed
Closed
Open
Open
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@Hypnosphi Hypnosphi Awaiting requested review from Hypnosphi

@igor-dv igor-dv Awaiting requested review from igor-dv igor-dv is a code owner

@thomasbertet thomasbertet Awaiting requested review from thomasbertet thomasbertet is a code owner

Assignees
No one assigned
Labels
addon: storyshots dependencies patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bertho-zero @storybook-safe-bot @shilman