Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD support for all versions of react #4808

Merged
merged 1 commit into from Nov 19, 2018
Merged

Conversation

ndelangen
Copy link
Member

  • manager will always use 1 version we control
  • users can not install any version of react
  • users can now specify a react alternative inmodule.resolve webpack config

@codecov
Copy link

codecov bot commented Nov 19, 2018

Codecov Report

Merging #4808 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #4808   +/-   ##
=======================================
  Coverage   35.55%   35.55%           
=======================================
  Files         560      560           
  Lines        6809     6809           
  Branches      911      911           
=======================================
  Hits         2421     2421           
  Misses       3912     3912           
  Partials      476      476
Impacted Files Coverage Δ
.../core/src/server/manager/manager-webpack.config.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99cf722...fdb673d. Read the comment docs.

@ndelangen ndelangen merged commit 9aec3f0 into next Nov 19, 2018
@ndelangen ndelangen deleted the separate-manager-preview-p4 branch November 19, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant