Resources addon to dynamically add/remove css #4622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # examples/official-storybook/package.json
…to addon-resources
…to addon-resources
nm123github
requested review from
danielduan,
Hypnosphi and
usulpro
as code owners
|
This might seem similar to recent resources-addon PR but is slightly different. This one allows you to switch between css files/themes predefined at compile time. This was a usecase that folks had asked and might be a good idea to deliver just that in this addon. The other addon (which is more of a codeinjector-addon) will be a different PR, (most likely will update the previous one). |
nm123github
removed request for
kazupon,
thani-sh,
rhalff,
saponifi3d,
alterx,
leonrodenburg,
thomasbertet,
Gongreg,
stijnkoopal,
dangreenisrael,
jbovenschen,
renaudtertrais,
alexandrebodin,
naipath,
z4o4z,
rmevans9 and
tmeasday
igor-dv
approved these changes
Nov 26, 2018
ndelangen
approved these changes
Nov 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: I think there might be use-cases where folks want to quickly hop between different css resources at runtime. Here is an addon that will help with that.
What I did