Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addon API: Clean preview hooks when removing a story #8408

Merged
merged 3 commits into from Oct 14, 2019

Conversation

Hypnosphi
Copy link
Member

@Hypnosphi Hypnosphi commented Oct 13, 2019

Partial fix for #8306
Also fixes #8298

How to test

Open any story, then remove the corresponding story or kind from sources

@Hypnosphi Hypnosphi added bug patch:yes Bugfix & documentation PR that need to be picked to main branch core labels Oct 13, 2019
@vercel
Copy link

vercel bot commented Oct 13, 2019

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/storybook/monorepo/kwyukfd1x
🌍 Preview: https://monorepo-git-clean-hooks-on-rename.storybook.now.sh

@vercel vercel bot temporarily deployed to staging October 14, 2019 00:45 Inactive
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🏅

@shilman shilman added this to the 5.2.x milestone Oct 14, 2019
@shilman shilman changed the title Clean preview hooks when removing a story Addon API: Clean preview hooks when removing a story Oct 14, 2019
@shilman shilman merged commit 2f8d7fc into next Oct 14, 2019
@shilman shilman deleted the clean-hooks-on-rename branch October 14, 2019 01:21
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Oct 14, 2019
shilman added a commit that referenced this pull request Oct 14, 2019
Addon API: Clean preview hooks when removing a story
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch preview-api
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Button knobs get extra callbacks on hot reload
2 participants