StoryDecorator and RenderFunction need to be exported.

[rakeshpai]

Migrating to 5.2.x has caused build errors in my TS project:

node_modules/@types/storybook__addon-info/index.d.ts:10:10 - error TS2305: Module '"path/to/project/node_modules/@storybook/react/dist/client"' has no exported member 'RenderFunction'.

10 import { RenderFunction, StoryDecorator } from '@storybook/react';
            ~~~~~~~~~~~~~~

node_modules/@types/storybook__addon-info/index.d.ts:10:26 - error TS2305: Module '"path/to/project/node_modules/@storybook/react/dist/client"' has no exported member 'StoryDecorator'.

10 import { RenderFunction, StoryDecorator } from '@storybook/react';
                            ~~~~~~~~~~~~~~

node_modules/@types/storybook__addon-knobs/index.d.ts:13:10 - error TS2305: Module '"path/to/project/node_modules/@storybook/react/dist/client"' has no exported member 'RenderFunction'.

13 import { RenderFunction } from '@storybook/react';
            ~~~~~~~~~~~~~~

node_modules/@types/storybook__addon-viewport/index.d.ts:7:10 - error TS2305: Module '"path/to/project/node_modules/@storybook/react/dist/client"' has no exported member 'StoryDecorator'.

7 import { StoryDecorator } from '@storybook/react';
           ~~~~~~~~~~~~~~

It looks like StoryDecorator and RenderFunction need to be exported from @storybook/react.

Expected behavior
Addons with TS should Just Work.

[rakeshpai]

Possibly related: #8121

[ndelangen]

You were using https://www.npmjs.com/package/@types/storybook__react before?

You should now get types without it, so there should be no need to import RenderFunction or StoryDecorator anymore.

[rakeshpai]

I was, but I've removed @types/storybook__react now. It looks like these errors aren't from my code though. It seems to be originating from the addons. So I'm not sure if this is anything I can do to fix, but I'll be happy to stand corrected.

[ndelangen]

Please remove @types/storybook__addon-info too, it's types will be incorrect.

I'd recommend migrating to the docs addon, which has types!

[rakeshpai]

Thanks, @ndelangen. I tried removing @types/storybook__addon-info, but addon-info's package.json doesn't have a types field, so its types aren't picked up automatically. https://unpkg.com/@storybook/addon-ionfo@5.2.1/package.json This is also true of the viewport addon. https://unpkg.com/@storybook/addon-viewport@5.2.1/package.json

Migrating to the docs addon is on the cards (it looks awesome!), but I was hoping to keep things working as I'm migrating.

[ndelangen]

@rakeshpai The viewport addon doesn't need any types. It's a register only addon.

Previously users would import a withViewport, but this has been deprecated.

The addon info is unofficially deprecated. We will not add types to it.
I recommend you silence the build error using some custom typescript code or any.

You could also take ownership of the @types/storybook__addon-info package and fix it, if you'd like. or use it as a starter to create a locally defined types for the package.

[rakeshpai]

Sorry, deleted my last comment, it was incorrect. I'll update this thread with my latest findings.

[rakeshpai]

Closing this issue since the specifics above have been resolved by removing the @types/... packages.

However, this hasn't been a smooth migration. I couldn't get addon-info working (due to the types issue above), and I couldn't get addon-docs working because of #7829. As a result, I've now lost my old addon-info-based documentation, and don't have any addon-docs-based documentation. I've had to roll-back to 5,1 as a result.

I'll revisit the migration once 5.2 support for TS is more solid. Cheers!

[shilman]

@rakeshpai we'll try to resolve the addon-docs typescript support soon in 5.3! you should also just be able to disable source code in docs for now as a workaround?

[good-idea]

@rakeshpai , I'm able to get this to work in 5.2 if my storybook config file is .js

(scratch that, nevermind)