Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrollbars always appear in the story iframe #7724

Closed
danielschwartz85 opened this issue Aug 8, 2019 · 5 comments
Closed

Scrollbars always appear in the story iframe #7724

danielschwartz85 opened this issue Aug 8, 2019 · 5 comments
Labels

Comments

@danielschwartz85
Copy link

danielschwartz85 commented Aug 8, 2019

Hi
The main story iframe is now always with scrollbars
Introduced in @storybook/react@2.1.10
We use this iframe to visual test the components, this creates false negative test images for the component screen.

To Reproduce
Steps to reproduce the behavior:

  1. install and run SB with the basic example

Expected behavior
Small components would not be in such a big div.

Screenshots
scroll

Additional context
Note that SB beta still has this issue but only with vertical scroll.
Thanks.

@shilman
Copy link
Member

shilman commented Aug 10, 2019

Closing this as a duplicate of #7646

Let me know if you think it's something else

@quentind
Copy link
Contributor

quentind commented Aug 12, 2019

@shilman Thanks for looking into this. I'm experiencing the same issue on 5.1.10 and I don't think it is the same problem as the one referenced in #7646 which pertain to the height of the preview area.

This issue is related to the viewport having unwanted scrollbars due to whitespace/margin on the body, which is a regression compared to live demo running on 5.1.3.

I've submitted a pull request which solves this issue.

Thanks!

@shilman
Copy link
Member

shilman commented Aug 13, 2019

Great Caesar's ghost!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.2.0-beta.29 containing PR #7750 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

@shilman
Copy link
Member

shilman commented Aug 13, 2019

Huzzah!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.1.11 containing PR #7750 that references this issue. Upgrade today to try it out!

@shilman
Copy link
Member

shilman commented Sep 25, 2019

ZOMG!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.3.0-alpha.3 containing PR #7742 that references this issue. Upgrade today to try it out!

You can find this prerelease on the @next NPM tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants