Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dark base theme hides js code snippet #7014

Closed
jeremytenjo opened this issue Jun 9, 2019 · 2 comments
Closed

dark base theme hides js code snippet #7014

jeremytenjo opened this issue Jun 9, 2019 · 2 comments
Assignees
@ndelangen
Labels
bug theming
Milestone
5.1.x

Comments

@jeremytenjo
Copy link

jeremytenjo commented Jun 9, 2019 •
edited

Describe the bug
Js Code snippet uses dark text when using storybooks dark theme, which results in the snippet disappearing.

To Reproduce
Steps to reproduce the behavior:

  1. Create readme and add ```
  2. Click reload page
  3. open notes panel/tab
  4. js snippet code will be hidden

Expected behavior
js snippet text should be white and legible

Screenshots
image

Thank you,
@jeremytenjo jeremytenjo changed the title dark base theme hides code snippet dark base theme hides js code snippet Jun 9, 2019
@shilman shilman added this to the 5.1.x milestone Jun 9, 2019
@ndelangen ndelangen self-assigned this Jun 11, 2019
@ndelangen ndelangen mentioned this issue Jun 11, 2019
Merged
@shilman
Copy link
Member

shilman commented Jun 13, 2019

Egads!! I just released https://github.com/storybookjs/storybook/releases/tag/v5.1.4 containing PR #7057 that references this issue. Upgrade today to try it out!

Closing this issue. Please re-open if you think there's still more to do.

@shilman shilman closed this as completed Jun 13, 2019
@jeremytenjo
Copy link
Author

Works great. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ndelangen ndelangen

Labels
bug theming
Projects
None yet
Milestone
5.1.x
Development

No branches or pull requests
3 participants
@shilman @ndelangen @jeremytenjo