Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bench script flakiness #27059

Closed
Tracked by #27018
yannbf opened this issue May 7, 2024 · 0 comments · Fixed by #27165
Closed
Tracked by #27018

Bench script flakiness #27059

yannbf opened this issue May 7, 2024 · 0 comments · Fixed by #27165
Assignees

Comments

@yannbf
Copy link
Member

yannbf commented May 7, 2024

The bench script seems to be flake for a few months already, always with the same error:

TypeError: Cannot read properties of null (reading 'page')
    at getPreviewPage (/tmp/storybook/scripts/bench/utils.ts:39:62)
    at tasks (/tmp/storybook/scripts/bench/browse.ts:47:27)
    at async Promise.all (index 0)
    at benchAutodocs (/tmp/storybook/scripts/bench/browse.ts:57:3)
    at browse (/tmp/storybook/scripts/bench/browse.ts:24:21)
    at Object.run (/tmp/storybook/scripts/tasks/bench.ts:33:31)
    at runTask (/tmp/storybook/scripts/task.ts:318:24)
    at run (/tmp/storybook/scripts/task.ts:464:28)

Example:
https://app.circleci.com/pipelines/github/storybookjs/storybook/75960/workflows/38365993-2b84-46d2-93de-908f951d015c/jobs/655000

https://app.circleci.com/pipelines/github/storybookjs/storybook/76312/workflows/11b5826e-b6ed-476e-82a5-20fc3a7b3797/jobs/657129

https://app.circleci.com/pipelines/github/storybookjs/storybook/76370/workflows/f8f8f596-03bf-4221-ab96-f199a4003c24/jobs/657475

Probably @shilman has thoughts on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants