Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show more of the package.json in the progressive loading guide #1267

Closed
justinbmeyer opened this issue Sep 7, 2017 · 3 comments
Closed

Show more of the package.json in the progressive loading guide #1267

justinbmeyer opened this issue Sep 7, 2017 · 3 comments
Labels
documentation guide

Comments

@justinbmeyer
Copy link
Contributor

stealjs_-_progressive_loading

People think to insert this where it says: "steal": "^1.5.0"
@matthewp
Copy link
Member

matthewp commented Sep 7, 2017

Do you mean in the progressive loading guide? How much would you suggest showing?

@justinbmeyer
Copy link
Contributor Author

We should probably get diffs to work and give people the ability to see all of it.

@matthewp matthewp changed the title Show more of the package.json Show more of the package.json in the progressive loading guide Sep 7, 2017
@justinbmeyer
Copy link
Contributor Author

justinbmeyer commented Sep 7, 2017 •
edited

One other thing I noticed is that there's not a link telling people to open /index.html. It's implied. This confused a bunch of folks. We should make sure we tell people which page to go to after every step (even if they should just refresh their current page).

m-mujica pushed a commit that referenced this issue Sep 12, 2017
Show full package.json content with diff
e15e2e4 
Closes #1267
@m-mujica m-mujica mentioned this issue Sep 12, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation guide
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justinbmeyer @matthewp