New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
npm config map
is not being set properly
#1208
Comments
This is caused by progressive fetching of package.jsons. The problem is that the left-hand side is not an npm module, so the code that is supposed to load preact-compat is never triggered. I suppose the fix is that we should fetch the right-hand side packages right away and not wait, if the left-hand side isn't npm. Going to look into what this would take to fix. |
Blocked by #1210 |
This restructions the npm normalize tests, putting the different QUnit.modules into their own test files to make it easier to add new tests. Also adds a breaking test for #1208
Breaking test added in ff9c28d |
This restructions the npm normalize tests, putting the different QUnit.modules into their own test files to make it easier to add new tests. Also adds a breaking test for #1208
This restructions the npm normalize tests, putting the different QUnit.modules into their own test files to make it easier to add new tests. Also adds a breaking test for #1208
How often can you reproduce it?
Description:
Steal config
map
does not seem to be being set properly.Steps to reproduce:
Here is a gist you can clone to show the issue.
https://gist.github.com/BigAB/ae311de12272af411969f477e6f8c1a5
preact-compat
should be a drop in replacement forreact
andreact-dom
and so map should swap them out fine. But in the gist, if you serve it you can see steal is still trying to importreact
.The relevant part of the gist is mostly this in `package.json:
Clone the gist. Run
npm install
. Serve the root. See in the console that react is trying to load andSystem.map
only has@loader/@laoder
and@steal/@steal
keys.Expected results:
I expect everything to work, for every call to
import React from 'react
would return thepreact-compat
module insteadActual results:
Steal fails to load
react
because it isn't there, and the config innpm
does not even appear to be merged intoSystem.map
Environment:
The text was updated successfully, but these errors were encountered: