@loader not defined in slim build

[pYr0x]

this PR and this line cause an error after build
https://github.com/stealjs/steal-tools/pull/850/files#diff-970f87aa3e6b874cd244518372a6e3f5R90
moduleId is @loader which is not defined.
the transpiled code looks like this:

		151,
		function(stealRequire, stealExports, stealModule) {
			var atLoader = stealRequire("@loader");
			var steal = {};
			steal.loader = atLoader;
			steal.done = function() {
				return Promise.resolve();
			};
			stealModule.exports = steal;
		}
	],

[m-mujica]

@pYr0x were you able to replicate this in a small app? A breaking example would be awesome.

The slim build should add an "@loader" shim right after "@steal" is added around here https://github.com/stealjs/steal-tools/blob/master/lib/build/slim.js#L64

steal-tools/lib/build/slim.js

Line 64 in 34fe1cf

addAtLoaderShim(),

[m-mujica]

I just hit this issue 🎉 :|

[pYr0x]

was what it?

[m-mujica]

There is a stream called addModuleIds and it adds the numeric ids to the load object of each node in the graph.

That stream also sets a normalize hook so the module identifiers are replaced by transpile

steal-tools/lib/stream/add_module_ids.js

Lines 31 to 36 in 34fe1cf

	// set a normalize hook for transpile so the regular module identifiers are
	// replaced with the short ids set in `node.load.uniqueId`
	options.normalize = function(name, load) {
	var node = load ? graph[load.name] : null;
	return node ? node.load.uniqueId : name;
	};

So, we pretty much push the @loader shim node to the graph, and it happens that the load object normalize expects there is undefined. ( in this case, the npm extension is the one calling normalize )

I had to change the function to check if graph[name] is available and get the numeric id from there.

makes sense?